fix: cp command S3toS3 --content-type flag

peak / s5cmd

Parallel S3 and local filesystem execution tool.

MIT License

2.71k stars 240 forks source link

fix: cp command S3toS3 --content-type flag #739

Closed 4o4x closed 4 months ago

4o4x commented 4 months ago

In s5cmd, the --content-type flag does not work when performing an S3 to S3 copy operation with the cp command.

Added tests addressing this issue.

resolves #738

denizsurmeli commented 4 months ago

Hi, thanks for the PR, can you edit the PR description that indicating https://github.com/peak/s5cmd/issues/738 is resolved by adding "Resolves #PR" in a seperate line. You can take a look at this for full reference.

ilkinulas commented 4 months ago

@4o4x is this PR ready for review? if not ready, convert it to draft please.

denizsurmeli commented 4 months ago

@4o4x tests fail. Can you fix them? Then the PR can be reviewed.