search

peak / s5cmd

Parallel S3 and local filesystem execution tool.
MIT License
2.7k stars 239 forks source link

add go 1.22 build #764

Closed lizzzcai closed 4 weeks ago

lizzzcai commented 1 month ago

add go 1.22 build support to fix some vulnerabilities.

igungor commented 1 month ago

Now that we have Go 1.23.2, could you update your PR to

lizzzcai commented 1 month ago

Now that we have Go 1.23.2, could you update your PR to

  • use go 1.23.x in goreleaser and docker builds
  • use 1.23.x, 1.22.x, and 1.21.x in github actions job matrices please? :)

Done. I assumed 1.19 and 1.20 are not needed anymore.

igungor commented 1 month ago

Now that we have Go 1.23.2, could you update your PR to

  • use go 1.23.x in goreleaser and docker builds
  • use 1.23.x, 1.22.x, and 1.21.x in github actions job matrices please? :)

Done. I assumed 1.19 and 1.20 are not needed anymore.

Correct. We test test latest 3 Go releases.

igungor commented 1 month ago

ci / qa (1.23.x, ubuntu) fails because staticcheck tool doesn't recognize a Go 1.23 feature yet. Updating honnef.co/go/tools to v0.6.0-0.dev fixes the issue.

I'd push the necessary changes but I don't have access to your repo.

Could you do the above version change in go.mod fileand run go mod tidy && go mod vendor please? This will bring the necessary changes. Please commit those changes and let's see if it's working.

lizzzcai commented 1 month ago

ci / qa (1.23.x, ubuntu) fails because staticcheck tool doesn't recognize a Go 1.23 feature yet. Updating honnef.co/go/tools to v0.6.0-0.dev fixes the issue.

I'd push the necessary changes but I don't have access to your repo.

Could you do the above version change in go.mod fileand run go mod tidy && go mod vendor please? This will bring the necessary changes. Please commit those changes and let's see if it's working.

Hi @igungor, by upgrading to honnef. com/go/tools v0.6.0-0.dev, the minimal Go version becomes 1.22.1.

igungor commented 1 month ago

ci / qa (1.23.x, ubuntu) fails because staticcheck tool doesn't recognize a Go 1.23 feature yet. Updating honnef.co/go/tools to v0.6.0-0.dev fixes the issue. I'd push the necessary changes but I don't have access to your repo. Could you do the above version change in go.mod fileand run go mod tidy && go mod vendor please? This will bring the necessary changes. Please commit those changes and let's see if it's working.

Hi @igungor, by upgrading to honnef. com/go/tools v0.6.0-0.dev, the minimal Go version becomes 1.22.1.

Hmm, it may not be the time to add Go 1.23 to the build matrix :(

lizzzcai commented 1 month ago

ci / qa (1.23.x, ubuntu) fails because staticcheck tool doesn't recognize a Go 1.23 feature yet. Updating honnef.co/go/tools to v0.6.0-0.dev fixes the issue. I'd push the necessary changes but I don't have access to your repo. Could you do the above version change in go.mod fileand run go mod tidy && go mod vendor please? This will bring the necessary changes. Please commit those changes and let's see if it's working.

Hi @igungor, by upgrading to honnef. com/go/tools v0.6.0-0.dev, the minimal Go version becomes 1.22.1.

Hmm, it may not be the time to add Go 1.23 to the build matrix :(

Hi @igungor , how about keep it to 1.22.x, 1.21.x and 1.20.x? Overall 1.22.x meets my requirements.

igungor commented 1 month ago

ci / qa (1.23.x, ubuntu) fails because staticcheck tool doesn't recognize a Go 1.23 feature yet. Updating honnef.co/go/tools to v0.6.0-0.dev fixes the issue. I'd push the necessary changes but I don't have access to your repo. Could you do the above version change in go.mod fileand run go mod tidy && go mod vendor please? This will bring the necessary changes. Please commit those changes and let's see if it's working.

Hi @igungor, by upgrading to honnef. com/go/tools v0.6.0-0.dev, the minimal Go version becomes 1.22.1.

Hmm, it may not be the time to add Go 1.23 to the build matrix :(

Hi @igungor , how about keep it to 1.22.x, 1.21.x and 1.20.x? Overall 1.22.x meets my requirements.

sounds good.

lizzzcai commented 1 month ago

Hi @igungor , updated. any timeline for fixing the timeout issue in new go version? and is there any plan to trigger a new release in the main branch (I saw a similar question #766)? Thanks.

igungor commented 4 weeks ago

Thanks. Increased s5cmd test command timeout to 10 minutes but the issue is still there. I'm not sure what the problem is on Go 1.21 macos test.

lizzzcai commented 4 weeks ago

Thanks. Increased s5cmd test command timeout to 10 minutes but the issue is still there. I'm not sure what the problem is on Go 1.21 macos test.

Hi @igungor , if I am not wrong, I think this line overwrite the timeout. Maybe I can just increase it or remove it?

igungor commented 4 weeks ago

Thanks. Increased s5cmd test command timeout to 10 minutes but the issue is still there. I'm not sure what the problem is on Go 1.21 macos test.

Hi @igungor , if I am not wrong, I think this line overwrite the timeout. Maybe I can just increase it or remove it?

It'd be great if you could remove the timeout line.

igungor commented 4 weeks ago

Thanks!

vrdn-23 commented 1 week ago

@igungor @lizzzcai Now that the new version has been updated to docker, would it be possible to cut a new release so that we can pull it using the release tag?

lizzzcai commented 1 week ago

@igungor @lizzzcai Now that the new version has been updated to docker, would it be possible to cut a new release so that we can pull it using the release tag?

Hi @vrdn-23 , I am expecting a new release as well. Probably need to check with the maintainer on the plan.