peakay / miglayout

Automatically exported from code.google.com/p/miglayout
0 stars 0 forks source link

Most recent 5.0-SNAPSHOT breaks example for Issue #6 #13

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The recent changes on 5.0-SNAPSHOT for JavaFX introduce major issues.
Using the latest build renders both my application and the (very simple) 
example[1] I created for Issue #6 unusable.

The commits are 61479b744417 and 96fcdad92c88, but both are so extensive that I 
can't yet pinpoint the issue.

[1]: https://github.com/UrsKR/miglayout-repaint

Original issue reported on code.google.com by ursreu...@gmail.com on 17 Apr 2014 at 7:30

Attachments:

GoogleCodeExporter commented 8 years ago
Yeah, I did make A LOT of changes. It was needed though since MigLayout code 
couldn't really handle the width/height hints during the flow through the Grid 
class. I will churn though all problems and solve them. Thanks for testing!

Original comment by mikael.g...@gmail.com on 17 Apr 2014 at 7:33

GoogleCodeExporter commented 8 years ago
Re: Testing, I'll gladly continue reporting what I see if it helps you in any 
way.

For reference, here are two Screenshots of how both samples should look like.

GoodSample.png was taken by Tom to prove issue #6 fixed,
GoodApp.png is from an older development version of the application, so some 
things have moved but it might give you an impression.

Original comment by ursreu...@gmail.com on 17 Apr 2014 at 7:39

Attachments:

GoogleCodeExporter commented 8 years ago
This regression should now be fixed. And the test in issue 6 was added as 
MigPaneTest15.

Original comment by mikael.g...@gmail.com on 17 Apr 2014 at 8:00

GoogleCodeExporter commented 8 years ago
Great work. The latest revision resolves the major issues and eradicates all 
performance problems I still witnessed!

However, some minor problems remain, I'll list them in separate issues.

Original comment by ursreu...@gmail.com on 18 Apr 2014 at 6:50