search

peakshift / makers.bolt.fun

https://makers.bolt.fun
GNU General Public License v3.0
31 stars 21 forks source link

Error during saving a story with multiple images #115

Closed reneaaron closed 2 years ago

reneaaron commented 2 years ago

Steps to reproduce

  1. Create a post with multiple images
  2. Click "Save as draft"
  3. See an error and the post hasn't been saved image

Analysis

image

I somehow expect the total filesize of the images embedded in the story to cause this problem as uploading & saving the story worked with only 1 image embedded.

MTG2000 commented 2 years ago

Hey Rene. First thing, I want to thank you for including the inspection error message 🙏

That's a weird error actually.... May I ask you how are you uploading the images?? Are you including a URLs for images hosted on some images-service?? Or are you for example embedding the images data directly in the post body??

reneaaron commented 2 years ago

I added them to the editor post body via copy & paste like here:

https://makers.bolt.fun/blog/post/story/56/lightning-payment-links-on-the-web

The limit seems to be around ~1MB of content. Given you want to embed some screenshots that could be a bit low, right?

MTG2000 commented 2 years ago

Ah, I see.

Yeah, we were not intending for images to be embedded directly in the post page. They are supposed to be uploaded on some images-hosting-service, and then only the URL is included.

Currently, we don't have an images-hosting-service yet, but that's definitely something that we will add soon. So you won't need to put the images data directly in the post body.

We have an issue opened for that #77, so hopefully it get resolved soon.

reneaaron commented 2 years ago

Got it, thanks. I will just go ahead an migrate those inline images to imgur. Thanks for the quick feedback! 💯