search

peakshift / makers.bolt.fun

https://makers.bolt.fun
GNU General Public License v3.0
31 stars 21 forks source link

A release that contains the roles-skills feature #144

Closed MTG2000 closed 2 years ago

netlify[bot] commented 2 years ago

Deploy Preview for makers-bolt-fun ready!

Name Link
Latest commit c6aea31159f59f3912bcba4fd5014252b64e6c22
Latest deploy log https://app.netlify.com/sites/makers-bolt-fun/deploys/6311efeed91dec000aa1fa55
Deploy Preview https://deploy-preview-144--makers-bolt-fun.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

barefoot-88 commented 2 years ago

Only thing I noticed was the line height above the : "ℹī¸ Can't find a specific skill/role that you think should be here? You can ask for it to be added here"

This line should be 1px high, not 2px as it currently is...

Screenshot 2022-09-01 at 16 15 07

Alternatively, we could use the info box as seen in the Submit Project journey (in Team ⚡ī¸ section). It might make sense to use this more consistently within the platform for cards like this... I guess same could be used in the Linked Wallets 🔐 card

Personally I'd opt for this solution!

Screenshot 2022-09-01 at 16 17 32
MTG2000 commented 2 years ago

Pushed an update that will make it look as the info box 👍

barefoot-88 commented 2 years ago

Nice work! Are we happy to merge? Currently seeing a "Merging is blocked" warning below, not sure which check has not been completed...?

MTG2000 commented 2 years ago

@barefoot-88 Merging is blocked until you or Johns approves this PR

However, before we merge this to production, do we want to make the 2 announcements together?? (Linking wallets & roles-skills)

barefoot-88 commented 2 years ago

We'll release them in this order:

We won't release roles and skills with a full article since it's a preliminary feature to tournaments etc. It also is fairly straight forward so doesn't require maybe as much detailed info as linked wallets etc. So personally I'm happy to go ahead and approve this PR so we can get the milestone 0.2 article out later today.

Sound good?

MTG2000 commented 2 years ago

Yup, sounds good.

barefoot-88 commented 2 years ago

The only thing I noticed on my final check was the button width on mobile, it doesn't quite fill the width of the container like it should do. You can see this correctly done on the "Basic Information" tab, but not Roles and Skills. Not the biggest error, so could merge without it done, but we should correct it at some point.

IMG_D9EF68771B01-1

Other than that I'm good to go!