peakshift / makers.bolt.fun

https://makers.bolt.fun
GNU General Public License v3.0
31 stars 21 forks source link

Feature/tagging project story #178

Closed MTG2000 closed 2 years ago

netlify[bot] commented 2 years ago

Deploy Preview for makers-bolt-fun-preview ready!

Name Link
Latest commit 48da38bffcb165e6177b82a857bf4451adc4b8d5
Latest deploy log https://app.netlify.com/sites/makers-bolt-fun-preview/deploys/633d758475fd26000831795a
Deploy Preview https://deploy-preview-178--makers-bolt-fun-preview.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 2 years ago

Deploy Preview for makers-bolt-fun-stories ready!

Name Link
Latest commit 48da38bffcb165e6177b82a857bf4451adc4b8d5
Latest deploy log https://app.netlify.com/sites/makers-bolt-fun-stories/deploys/633d7584a58fad0009e57864
Deploy Preview https://deploy-preview-178--makers-bolt-fun-stories.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

barefoot-88 commented 2 years ago

QA

Web

Feed page

i). Increase avatar sizes to 32px. At the moment it feels too small on web. ii). What size fonts are we using for mobile for these header items? They do feel a bit small. Perhaps 14px + 12px will also be ok for size. Can we try that out? Looks like they might currently be smaller than that... iii). Dates for the post. I think it makes sense to use "X days" until the one month mark. And from then onwards we should have the format "X Jan" (so only show the first 3 letters of the month (Jan, Feb, Mar, Apr, May, Jun, Jul, Aug, Sep, Oct, Nov, Dec)

Screenshot 2022-10-05 at 09 33 02 Screenshot 2022-10-05 at 09 43 12

Post page

i). When it's the makers post, we should show the edit button in the top right hand corner of the post (so the right side of the header... see design below). If we could eventually have the functionality of sharing the post directly via a link or to Twitter, we can show the twitter logo etc next to it... (see below) ii). I've noticed on both web and mobile the height of the image is often cropped/clipped and isn't full height. Is this intentional? I think it's better to display the full image if possible for max visual impact. Perhaps we could set a max height (320px or something). This issue is also on mobile... iv). The date text (below the makers name/avatar) should be Paragraph 2 (so less weight).

Screenshot 2022-10-05 at 09 45 01

Create a post

i). "Tag a project" text should be the same as the "Add up to X popular tags" text above. ii). Both of these text items should be the same colour (un-selected/empty state) as the Heading

Screenshot 2022-10-05 at 09 57 50

Mobile

Post page

i). Same clipping issue with the image of the post (again, we could set a max height.. same as above, 320px?)

Screenshot 2022-10-05 at 09 49 45

Other QA bits

Explore page

i). I noticed the order of these elements is a bit off. On mobile these should be stacked as follows:

ii). The spacing between these 4 elements should be 16px. It looks too spaced out on mobile.

Screenshot 2022-10-05 at 09 51 06 Screenshot 2022-10-05 at 09 52 23

Maker profile

i). Just like the projects page, the skills section on the maker profile should have spacings of 8px between the chips

Screenshot 2022-10-05 at 09 56 17

Create a post/story

i). The upload image works really well, functionality is great. However, could we please change:

Screenshot 2022-10-05 at 10 12 09
MTG2000 commented 2 years ago

@barefoot-88 Done 👍

barefoot-88 commented 2 years ago

Final QA

@MTG2000

i). These two texts should be the same colour... (Cool grey) #94A3B8

Screenshot 2022-10-05 at 12 45 30

Everything else looks great!