peakshift / makers.bolt.fun

https://makers.bolt.fun
GNU General Public License v3.0
31 stars 21 forks source link

(WIP) Semantics and new navigation #244

Closed johnsBeharry closed 1 year ago

johnsBeharry commented 1 year ago

TODO

netlify[bot] commented 1 year ago

Deploy Preview for makers-bolt-fun ready!

Name Link
Latest commit fd159e73ad484bfa6dff83de661786b0a27bec64
Latest deploy log https://app.netlify.com/sites/makers-bolt-fun/deploys/64570146ce5d3200085481b4
Deploy Preview https://deploy-preview-244--makers-bolt-fun.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

MTG2000 commented 1 year ago

@johnsBeharry Could you clarify more on points 3 & 5 in the tasks list above?

johnsBeharry commented 1 year ago

Four point number three basically make the navigation work. As we discussed this morning.

For point number 5 in your first version you used a class which cuts off the text at a certain amount of limes. I couldn't remember which it was but I was thinking that we continue to show comments up to 5-7 lines

I noticed that the names of projects in the postcard or are clipped after 15 characters. I didn't want to change it because I wasn't sure why.

MTG2000 commented 1 year ago

I noticed that the names of projects in the postcard or are clipped after 15 characters. I didn't want to change it because I wasn't sure why.

Because maybe there are some projects names that are too long (longer than 15 chars)

johnsBeharry commented 1 year ago

Too long would be more than 15 characters though. What's the constrain that determines too long?

By the way this one shouldn't be blocking, you can ignore that item. it was mostly for me to explore and ask about for my other updates.

MTG2000 commented 1 year ago

@johnsBeharry You can review & test this PR now if you want.

johnsBeharry commented 1 year ago

Looks good to myself... for now.