feat(billboard): setup of a 1.5 min rotating ad space

johnsBeharry commented 12 months ago

hey @MTG2000 I've added some functionality but I think you should look at it before I merge cause it's not my usual basic updates. Still pretty basic though 😅

Also I can't seem to get the background image to show up :/ not sure what to do

You'll be able to preview on the /feed page

netlify[bot] commented 12 months ago

Deploy Preview for boltfun ready!

Name	Link
Latest commit	e178b21564a564361b26651a1f3cc0442ce5b344
Latest deploy log	https://app.netlify.com/sites/boltfun/deploys/6502c235661daa0008d84bac
Deploy Preview	https://deploy-preview-272--boltfun.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

MTG2000 commented 11 months ago

Looking good.

But just 2 things before you merge:

I see a lot of the logic of choosing the random billboard item in the "FeedPage". It's usually better to isolate this kind of code in its own: service OR custom-hook OR class. (And preferably, close to the Billboard component rather than the FeedPage, since this logic is a part of how the Billboard component is expected to behave.)
Regarding why the bg-image isn't shown correctly, the reason is because tailwind doesn't allow dynamic classes that it doesn't know their values at build time. Check this section from their docs: https://tailwindcss.com/docs/content-configuration#dynamic-class-names

In this specific case, I recommend you just pass the bg url directly to the style props of the component.

MTG2000 commented 11 months ago

Pushed a fix for this one.

peakshift / makers.bolt.fun