search

peakshift / peakshift-website

🖼 Finally a portfolio site?
http://www.peakshift.com
3 stars 2 forks source link

Typography / Copy missing styles from old journal template to the new stylesheet #8

Closed johnsBeharry closed 6 years ago

johnsBeharry commented 6 years ago

Along with the portfolio launch, we hope to have a journal where we can post articles of ideas, and happenings @peakshift.

The journal will share a stylesheet with the portfolio, so we need to integrate the styles from the old journal template into the new scss file.

Outlined are some of the elements / styles that need to be added to the new .scss stylesheet and journal.html template.

screen shot 2018-04-19 at 11 21 09 pm
johnsBeharry commented 6 years ago

Could you get started on this one @micey969, I think until the designs for the team page are completed #6 is going to be blocked.

micey969 commented 6 years ago

Okay, let me see if I have this correct (I'm trying to watch the code and the picture to see):

  1. you want me to add the comment section to the journal and it's styles and javascript
  2. you want me to add the styles for that "adjective" quote
  3. Add the styles for the links
  4. You want the style for the same spacing before each article?

Can you clarify in case I missed something please?

johnsBeharry commented 6 years ago

@micey969

  1. Please DO NOT take any javascript, or styles for the comments panel that pops out on the right
  2. this is called a citation, and the styles should be applied to <cite>
  3. 👌
  4. I'm not sure what you're referring to
micey969 commented 6 years ago
  1. Okay, so you just want the layout of that section and its styles?
  2. I see it has a class of "pos" but I don't see it in the stylesheet (I'll look for it in the others)
  3. The small circle you had at the beginning of the article, I was asking if you wanted the indentation/ spacing styles for the article
johnsBeharry commented 6 years ago

@micey969

  1. I can hop on a call with you if you'd like to get further clarification.
  2. sure. i haven't looked at the styles myself so i take your word for it.
  3. please look a bit more at the screenshot, or view the template in the browser - the circle you're referring to is around a paragraph symbol which is besides the paragraphs.
micey969 commented 6 years ago

Okay, I found the citation style in a bootstrap stylesheet. And I found the paragraph symbol you mentioned. I guess we can hop on a call to clarify the first one.

johnsBeharry commented 6 years ago

@micey969 I just checked out the current version of the journal styles, and it looks like the image and some of the hover effects are missing. Please add them in.

johnsBeharry commented 6 years ago

Found 2 Problems: