search

peal / vole

A GAP package for backtrack search in permutation groups with graphs
https://peal.github.io/vole
Mozilla Public License 2.0
8 stars 2 forks source link

Refactor #1

Closed WizardOfMenlo closed 4 years ago

WizardOfMenlo commented 4 years ago

Hi! I have refactored everything to a module structure as mentioned in the email. Personally I like this structure quite a bit more. I have fixed a couple of clippy issues as well. All tests seem to be passing fine, and I think that nothing should have silently broken.

WizardOfMenlo commented 4 years ago

Only thing that I have not tested yet is Vole, as I am on windows at the moment, I think it might be worthwhile to develop a cfg based solution to test on other OSes? Might have a crack at it tonight

WizardOfMenlo commented 4 years ago

Just as a note, this should make it possible to handle it on any non linux system. Not sure what the use case is exactly, but this way the existing behaviour should be untouched

ChrisJefferson commented 4 years ago

The 'vole' stuff is very unfinished :)

The idea is that the program can communicate with another process (the GAP system in this case), and do some simple two-way communication.

While I could obviously use something fancier than unix pipes & json, it's quick to get going and anything else would need implementing both here, and on the GAP side. I briefly looked at zeroMQ, but there seemed to be several different Rust bindings, each in a different state of buggyness/unfinishedness.

WizardOfMenlo commented 4 years ago

Ah ok perfect, yeah all this kind of binding stuff is often not very mature. I have looked at this which is at least a step up over the raw c bindings (it aims to have a Rust-y API, even if that might sacrifice completeness) but again that will depend on exactly what we want to do.