search

pear / DB

http://pear.php.net/package/DB
9 stars 33 forks source link

release version 1.12.0 #20

Closed schengawegga closed 6 months ago

schengawegga commented 11 months ago

prepare and release version 1.12.0

guilheb commented 8 months ago

Curious, when is 1.12.0 planned?

schengawegga commented 8 months ago

@guilheb in wich PR you are interested? I plan to split the versions a bit, because of setting the getVersion() Method as static, wich changes the behavior of the package and results in a new major version, to keep it backwards-compatible.

guilheb commented 8 months ago

@schengawegga I'm only looking for PHP 8.2 compatibility

schengawegga commented 8 months ago

@guilheb i´ve done a PR #21 to become fully PHP8.2 ready. After verifying this PR, i will release the version 1.12.0.

ashnazg commented 7 months ago

21 is merged now, @schengawegga

demeritcowboy commented 7 months ago

@schengawegga Does your comment earlier about getVersion refer to https://github.com/pear/DB/pull/17 and you'd like to leave that out of 1.12.0? For me the answer to "in which PR you are interested" is that I would be interested in all of them.

Thanks for everyone's work keeping this package updated!

MarkMaldaba commented 7 months ago

@guilheb in wich PR you are interested? I plan to split the versions a bit, because of setting the getVersion() Method as static, wich changes the behavior of the package and results in a new major version, to keep it backwards-compatible.

I don't think this is correct, is it? Labelling a method as static does not prevent it from being called in a non-static context, but just prevents errors being raised in a static context on more recent PHP versions.

In other words, $obj->apiVersion() will still work just fine.

As per PR #17:

Note that this change will not break any misbehaving code that is instantiating the DB class in order to call this method - it is quite acceptable to call a static function on an object instance.

Therefore this should not prevent a 1.12 release.

wideareashb commented 7 months ago

Can this be released?

schengawegga commented 7 months ago

Thanks for all your comments. I am very busy at the moment. I will have a look at it next week.

schengawegga commented 7 months ago

@guilheb in wich PR you are interested? I plan to split the versions a bit, because of setting the getVersion() Method as static, wich changes the behavior of the package and results in a new major version, to keep it backwards-compatible.

I don't think this is correct, is it? Labelling a method as static does not prevent it from being called in a non-static context, but just prevents errors being raised in a static context on more recent PHP versions.

In other words, $obj->apiVersion() will still work just fine.

As per PR #17:

Note that this change will not break any misbehaving code that is instantiating the DB class in order to call this method - it is quite acceptable to call a static function on an object instance.

Therefore this should not prevent a 1.12 release.

you´re right. but the minor release is because of "Add Driver SQLite3 #18" , too

wideareashb commented 6 months ago

So does that mean that this can be released as 1.12.1

schengawegga commented 6 months ago

@wideareashb no, it will be released as 1.12.0. I will do this in the next days. But before, i will do a quick test to check the compatibility with PHP 5.0. If we need to update the dependencies, too.

schengawegga commented 6 months ago

Version 1.12.0 released

Neustradamus commented 6 months ago

@schengawegga: Good job!

Neustradamus commented 6 months ago

And the 1.12.1 too:

Thanks @remicollet too.