search

pear / DB

http://pear.php.net/package/DB
9 stars 33 forks source link

fix fetch args #34

Closed ashnazg closed 3 months ago

ashnazg commented 5 months ago

Issue #33 . This fixes the args for oci_fetch_array. I tried to keep the same $moredata logic, based on (what I think is) original ocifetchinto return behavior of integer of rows fetched.

@schengawegga , I'll need you to test this since I don't have the right environment.

schengawegga commented 4 months ago

Thank @ashnazg for der PR. I will look at it soon.

schengawegga commented 3 months ago

@ashnazg Thanks for your PR. I pushed a second commit, becuase at the end of the query dataset, oci_fetch_array returns a false value, to end a while loop, that is not acceptable by count(). I will doublecheck all other changed functions, on my last PHP8.2 release, if there any other functions with the same issue than oci_fetch_array. Could you do a review of my comitted change, please?