search

pear / DB

http://pear.php.net/package/DB
9 stars 33 forks source link

added php72 #5

Closed kokspflanze closed 6 years ago

kokspflanze commented 6 years ago

added php71 and php72 in travis.yml fixed countable warnings

hypermkt commented 6 years ago

LGTM! ( I am not a maintainer of PEAR so I can't merge but LGTM ) I hope to review and merge somebody.

hypermkt commented 6 years ago

@convissor @LawnGnome It's not my PR but I also hope to add PHP 7.1 and 7.2 to travis. so Could you review this PR?

till commented 6 years ago

PR LGTM also. Not entirely sure why Travis-CI didn't run. Does it need to be enabled for this repo?

till commented 6 years ago

@kokspflanze Can you add a commit? I think I enabled the repository on Travis-CI.

kokspflanze commented 6 years ago

@till added =)

kokspflanze commented 6 years ago

thats why 5.3 fail=(

PHP 5.3 is supported only on Precise.
See https://docs.travis-ci.com/user/reference/trusty#PHP-images on how to test PHP 5.3 on Precise.
Terminating.
till commented 6 years ago

@ashnazg @cweiske Can we do a PEAR-DB-2.0.0 release with these additions to show that we no longer support PHP 5.3? (Had this in my notifications for too long.)

ashnazg commented 6 years ago

@till I'll try to look at it this week.

kokspflanze commented 6 years ago

for php5.3 i added a matrix entry to use precise as dist

mpdude commented 5 years ago

@ashnazg and @cweiske

A new release with these changes would really be helpful, as Composer does not pull in transitive dev dependencies unless you relax preferred stability constraints.

In other words, you cannot get rid of warnings on PHP 7.2 if pear/db is a transitive dependency.

I am not sure about the PEAR release process and maintainership: Can you release/tag a new version here if it does not at the same time show up in pear.php.net?

If you really care about leaving PHP 5.3 as a supported platform behind, tag 1.10.0 - you could then still release critical bug fixes for PHP 5.3 as 1.9.x.

No need for a 2.0 release IMO, no breaking changes here.

ashnazg commented 5 years ago

@mpdude released as v1.9.3.