Closed justechn closed 12 years ago
To be honest, outside of my skillset/domain knowledge. Patches welcome!
Unfortunately, I'm not familiar with the UPC-E
Well then maybe you can help me understand the code. For example, what is the $_codingmap array used for? I don't know what all the 1's and 0's are. It does not look like they are used by anything in the UPC-A code.
foreach ($this->_codingmap[$value]['L'] as $bar) {
if ($bar) {
$writer->imagefilledrectangle(
$img,
$xpos,
0,
$xpos + $this->getBarcodeWidth() - 1,
$this->getBarcodeHeight(),
$black
);
}
$xpos += $this->getBarcodeWidth();
}
This is one of the few places that use codingmap, but the $bar variable is only used in the if() and nowhere else. I don't see anywhere that it is using the 0's and 1's
I got it figured out
now, how do I attach files???
@ryanmc2033 it might be a bit of a learning curve, but I'd encourage you to create a 'fork'. You can edit files online, which might be ok if it's a 1-2 line fix; or git clone and edit locally.
Once you have done changes, there's a button for "pull request" - hit that, and you'll have created basically a patch request for us to adopt.
I'll try if I get time.
On Fri, Apr 20, 2012 at 10:46 AM, Daniel O'Connor < reply@reply.github.com
wrote:
@ryanmc2033 it might be a bit of a learning curve, but I'd encourage you to create a 'fork'. You can edit files online, which might be ok if it's a 1-2 line fix; or git clone and edit locally.
Once you have done changes, there's a button for "pull request" - hit that, and you'll have created basically a patch request for us to adopt.
Reply to this email directly or view it on GitHub: https://github.com/pear/Image_Barcode2/issues/20#issuecomment-5248353
ryanmc2033 implemented UPC-E generator.
What are the chances of getting a UPC-E generator? I am trying to wrap my head around all this and it is giving me a headache. I will keep working on it, but I'm sure someone else could do it faster.
Thanks