search

pear / Net_LDAP2

Object oriented interface for searching and manipulating LDAP-entries
http://pear.php.net/package/Net_LDAP2
GNU Lesser General Public License v3.0
10 stars 6 forks source link

Fixes for PHP 8.1 #13

Closed cweiske closed 11 months ago

cweiske commented 1 year ago

The tests pass in a docker container with PHP 7.4, 8.0, 8.1 and 8.2.

@hbeni please review + merge.

Neustradamus commented 1 year ago

@hbeni: Have you seen the @cweiske PR?

cweiske commented 11 months ago

Released as v2.3.0

Neustradamus commented 11 months ago

@cweiske: Thanks for merging! Do not forget to create the release here (in more the tag):

cweiske commented 11 months ago

Why is a tag not enough?

Neustradamus commented 11 months ago

@cweiske: At right on https://github.com/pear/Net_LDAP2/ Releases 1 v2.2.1 (Latest) on Feb 8

cweiske commented 11 months ago

I know that there is one release already. But I ask again: Why is a tag not enough? What does the release give us in addition?

colisee commented 11 months ago

Hi @cweiske ,

Together with @effgarces, I am participating to the repository librebooking/app and I realized that our librebooking sources contained an old copy of Net_LDAP2.

I wish to remove the old Net_LDAP2 sources and use instead Net_LDAP2 through the PEAR application repositories. In such case, wouldn't you need to add a new release in order to include the latest fix into PEAR?

Thanks.

cweiske commented 11 months ago

Yes, this would be necessary. But a release on pear.php.net is different from a release on github. I also won't do a release on pear.php.net. If others have the time and will to do that - please go on.

colisee commented 11 months ago

OK: got it

I saw that the pear Net_LDAP2 repository is no longer maintained. I will check if it is worthwhile for me to takeover the lead on that pear repository for the benefit of our librebooking project.

Neustradamus commented 11 months ago

@colisee: Good catch, pear.php.net is not updated when a version is released on GitHub!