search

pear / Net_LDAP2

Object oriented interface for searching and manipulating LDAP-entries
http://pear.php.net/package/Net_LDAP2
GNU Lesser General Public License v3.0
10 stars 6 forks source link

rootDse() does not use in-memory cache #8

Open alecpl opened 1 year ago

alecpl commented 1 year ago

Looks to me that true || here needs to be removed: https://github.com/pear/Net_LDAP2/blob/0cbfdadca4b55cb7543ad0a6b994fe0e4ed5c3c1/Net/LDAP2.php#L1505

hbeni commented 1 year ago

Like it is now, always a fresh object is fetched. I don't remember the reason for this, but it may be a left over artifact from development.

From the first glance, I think too that the true should be removed, however this needs rigid testing before changing.