search

pear2 / Net_RouterOS

This package allows you to read and write information from a RouterOS host using the MikroTik RouterOS API protocol.
http://pear2.php.net/PEAR2_Net_RouterOS
241 stars 116 forks source link

Changed login method #48

Closed NotSoJose closed 5 years ago

NotSoJose commented 5 years ago

I changed the Login code in Client.php since the one on Master branch doesn't work in connection with 6.45. The code has been based on the issue: #39 .

boenrobot commented 5 years ago

A better version of this change has already been done in the develop branch.

This project follows the nvie workflow, whereby only official tagged releases go into master.

There is no official release yet, as I haven't generated a PHAR, but you can use composer with dev-develop as the version, even right now.

boenrobot commented 5 years ago

The problem isn't with the git model, it's with the PHAR tools.

The nvie model assumes you have an easy deployment pipeline, meaning that you can easily do a "hotfix" release even if "develop" is taking it's sweet time.

I can easily just tag a commit and go to master... But that would still only cover Composer users, not PEAR and PHAR users.

Even switching to a different PHAR building flow takes time that I don't have enough of these days 😢