search

pear2 / pear2.php.net

PEAR2 website
http://pear2.php.net/
Other
19 stars 9 forks source link

GitHub API fix #21

Closed boenrobot closed 12 years ago

boenrobot commented 12 years ago

It seems GitHub have removed their v2 API, since June, as described in their change log. The links on the site still work, but they appear completely frozen.

The patch here should make the issue links work again, with the v3 API. It also abstracts away a few things in the model to make it a little more DRY.

saltybeagle commented 12 years ago

Whoops — [Thu Aug 09 16:31:00 2012] [error] [client 129.93.245.105] PHP Fatal error: Cannot pass parameter 4 by reference in /var/www/html/pear2.php.net/src/PEAR2Web/Models/Package.php on line 20, referer: http://pear2.php.net/

boenrobot commented 12 years ago

facepalm

Well, suits me right for not actually testing a live copy. I thought the $count in str_replace was supposed to place a limit on replacements, and now I see that's not what it's for.

Sorry about that. I've updated my branch. It's just a matter of removing the ",1" part. Should I do a new pull request, or could you perhaps "re"-pull/fix it in this copy?