search

pearcej / cppds

Problem Solving with Algorithms and Data Structures using C++
Other
11 stars 76 forks source link

Add Asset folder #469

Closed Hamdy092002 closed 8 months ago

Hamdy092002 commented 8 months ago

Description

I added all the images to the asset folder.

Related Issue

fix #468

How Has This Been Tested?

To test, I followed this:

  1. I make sure all the images are in the assets folder.
  2. I test it by linking a sample image: image
Hamdy092002 commented 8 months ago

reviewed by @demekenega

demekenega commented 8 months ago

@Hamdy092002 's fix looks good. It includes all the images in the asset folder. The one thing that I am not sure about is whether a PDF file should be in the asset folder or not. Other than that, everything looks good. This pull request will help us to fix image-related issues because almost all the images in the book are not showing because they have wrong links. @pearcej

pearcej commented 8 months ago

I would like all of the assest organized into sub-folders by the names of the chapters.

I can do this later today.

pearcej commented 8 months ago

I have added the assets/AlgorithmAnalysis folder, so you can now work on that chapter (Chapter 2)