search

pearl-core / pearl

Pearl is a lightweight package manager for automating reproducible environments between different systems (Linux and OSX). It can be used for dotfiles, plugins, programs and any form of code accessible via git.
GNU General Public License v3.0
227 stars 24 forks source link

Fix variables PEARL_PKGNAME PEARL_PKGREPONAME #88

Closed linkseed closed 5 years ago

linkseed commented 5 years ago

Correcting the variable value of boot vim. I think the values of REPONAME and PKGNAME are exchanged.

Thank you for making pearl.

fsquillace commented 5 years ago

Awesome catch!

Can you please create the pull request with dev as the base branch?

Thanks a lot for this PR!

fsquillace commented 5 years ago

I have just noticed that this problem occur in emacs boot too: https://github.com/pearl-core/pearl/blob/master/boot/emacs/pearl.el#L5-L6

Can you make the same change in there?

Cheers

linkseed commented 5 years ago

Can you make the same change in there?

@fsquillace Probably the same kind of correction is good, but I have never used emacs, so I can not check if the modification is correct.

fsquillace commented 5 years ago

Yes, unfortunately the two boot files vim and emacs are the only ones which are not tested in pearl codebase.

There are also two old issues about that:

If you want you can make the change and I will verify that as soon as it get pushed. Since the branch used here is dev, it will not affect production code. The regex will be the same as the one you used in vim.

Cheers

fsquillace commented 5 years ago

I checked and it works fine in Emacs too.

Thanks again!

linkseed commented 5 years ago

I appreciate your generous and prompt response.