search

pearofducks / ansible-vim

A vim plugin for syntax highlighting Ansible's common filetypes
MIT License
796 stars 98 forks source link

Add default to highlight links in ansible_hosts.vim #82

Closed rhodesn closed 5 years ago

rhodesn commented 5 years ago

Adding default causes the link to be ignored if there is already a link in place for the group. This would allow users/colorscheme owners to override the links set in syntax/ansible_hosts.vim.

See :hi-link for more info.

Would resolve #81.

pearofducks commented 5 years ago

I think this is a good change, but would like to keep the diff pretty straightforward. Can you remove your ansible_attribute_highlight block changes, and just add default to line21?

My thinking being if someone wants to override this value, they probably won't have ansible_attribute_highlight set in the first place. :)

I'm up for this change being propagated to ansible.vim as well, but probably just the syntax groups that file defines - e.g. the jinja/yaml overrides would probably have to stay.

rhodesn commented 5 years ago

I amended the original commit to keep the history cleaner. I've also updated syntax/ansible.vim, however taking your advice I've ignored the yaml/jinja groups, and also any ansible-vim groups which have been set with a global config flag. Let me know if you want any other changes made.

pearofducks commented 5 years ago

Thanks for this, appreciate it!