search

pearofducks / rollup-plugin-dev

development server for rollup with additional logging and options
MIT License
61 stars 9 forks source link

silent option should probably also hide plugin log messages also #4

Closed sormy closed 4 years ago

sormy commented 4 years ago

Some plugins like rollup-plugin-progress do not play well together with rollup-plugin-dev since they are both trying to output on console. The solution could be to make silent to also hide plugin logs.

pearofducks commented 4 years ago

I'll look into this, thanks for reporting this and the other issue!

pearofducks commented 4 years ago

Does just the one console emit here cause rollup-plugin-progress to lose its mind?

I'm looking around if any other plugins try to hijack console like this - as well as what other progress-meter plugins actually do - it's a bit nutty to make it so any other plugin can't reliably log info to console. :)

sormy commented 4 years ago

Yes, probably moving console.log to another type of hook could fix the issue.

sormy commented 4 years ago

options hook is sync and is invoked first, could be a good place to output initial information

pearofducks commented 4 years ago

Closed in v1.1.0