search

pearselab / MADcomm

Make A Database of ecological communities
Other
1 stars 15 forks source link

CLAMP neogene wrapper #35

Closed Spencerbrucehudson closed 5 years ago

Spencerbrucehudson commented 6 years ago

Neogene wrapper works, but some potential data frame nomenclature issues we should discuss at some point. Can proceed with paleogene and cretaceous wrappers when time permits.

Spencerbrucehudson commented 6 years ago

Checks failed? Waaah. By the way - Seems like there's an issue with an internal object called species and the function 'species'. Will fix along with a push for the paleogene and cretaceous wrappers. Seems like the same wrapper works for those data sets.

Spencerbrucehudson commented 6 years ago

Scrap first commit 'CLAMP neogene wrapper' and run with 'All CLAMP wrappers + edits'

willpearse commented 6 years ago

Sorry to have taken so long getting to this, Spencer, and thank you for writing this because it looks fantastic.

I'm a bit confused because the first commit you made (https://github.com/pearselab/nacdb/pull/35/commits/ff5b885761ec285669625311a2b61fc4652231c7) is being read by GitHub as totally re-writing the entire file. Is something weird going on with you file encodings? Is there a chance you could try "starting again" by pulling a fresh clone of the repo, copy-pasting your new code in at the bottom of the file, and then making a fresh pull request?

I ask because I think this is also the cause of the build error. The error is because there are non-ASCII characters in the file, which I think is either (1) an older build of NACDB or (2) something weird going on with your file encodings.

Does that make sense? Sorry it's such a pain. You've earned some massive brownie points here for all the work you've put in - THANK YOU!!!