search

peartherapeutics / bitrise-aws-device-farm-file-deploy

MIT License
6 stars 15 forks source link

Would need to export the upload ARN to be able to chain with other command #9

Closed otusweb closed 7 years ago

otusweb commented 7 years ago

It would be great to export the uploadARN to be able to chain this step with other step to start a run

envman add -k AWS_TEST_BUNDLE_IPA_ARN -v $uploadARN

fadookie commented 7 years ago

@otusweb good idea. please send a PR (also make sure to quote the variable.) In the test runner step, I think the way this should be handled is with an optional test_package_arn input. If it's not present, it would fall back to its current behavior of looking up the most recent upload with the provided test_package_name. So test_package_name should also be made optional, although the step would fail if neither was provided.

Would you be willing to make a PR for this? In our current use case, we have separate repos/ci jobs for deploying our test package and for actually running the tests which is why my initial implementation doesn't have this sort of wiring.

otusweb commented 7 years ago

If i get some spare time, i might. The problem i thought about (for which i don't have a solution) is how to handle multiple step that create an upload. There need to be a way to know the ARN for the test package upload and for the app upload. Any idea?

fadookie commented 7 years ago

Bitrise CLI just added the ability to re-name an exported envvar from a step.

On Tue, Oct 4, 2016, 12:39 PM Olivier Destrebecq notifications@github.com wrote:

If i get some spare time, i might. The problem i thought about (for which i don't have a solution) is how to handle multiple step that create an upload. There need to be a way to know the ARN for the test package upload and for the app upload. Any idea?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/peartherapeutics/bitrise-aws-device-farm-file-deploy/issues/9#issuecomment-251490585, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGwrGqwy7qSkwJG4KG8UEjebmrKMaAjks5qwqtpgaJpZM4KE4To .

otusweb commented 7 years ago

That might be a good way. unfortunately, I don't have a project that needs this right now, so i won't get to it any time soon.