search

peartherapeutics / bitrise-aws-device-farm-runner

Custom Bitrise step to run tests on aws device farm
MIT License
10 stars 21 forks source link

testing with unmetered device slot #22

Closed andreschab90 closed 7 years ago

andreschab90 commented 7 years ago

Does the runner use the purchased device slot, when i started a test run?! Is there a possibilty to use the unmetered billing with your runner?

best regards André

fadookie commented 7 years ago

@andreschab90 I'm not sure. I have not used purchased device slots yet. I'd suggest you have a look at the device farm docs to see if you can find any info on that.

Maybe you could try kicking off a test run and then check your metering/billing information afterwards to see if it was billed correctly?

andreschab90 commented 7 years ago

@fadookie i can confirm, that this device runner works only for the metered billing method. i have purchased a device slot, but the runner still uses the metered billing method. If i set up a test manually via the webUI, then i have to choose the billig method. The default billing method ist "metering"

fadookie commented 7 years ago

@andreschab90 Thanks. Looks like ScheduleRun endpoint takes an (optional) billingMethod property: https://docs.aws.amazon.com/devicefarm/latest/APIReference/API_ScheduleRunConfiguration.html#devicefarm-Type-ScheduleRunConfiguration-billingMethod

I don't have time to make this change myself but I'd be open to a PR that adds billing method as an input to this step. I think it should have the same default as it does now (metered.) It should be passed to aws-cli via the --configuration flag: https://docs.aws.amazon.com/cli/latest/reference/devicefarm/schedule-run.html

Relevant step code is at https://github.com/peartherapeutics/bitrise-aws-device-farm-runner/blob/master/step.sh#L188

andreschab90 commented 7 years ago

@fadookie PR is created

fadookie commented 7 years ago

closed by https://github.com/peartherapeutics/bitrise-aws-device-farm-runner/pull/26