search

peartherapeutics / bitrise-aws-device-farm-runner

Custom Bitrise step to run tests on aws device farm
MIT License
10 stars 21 forks source link

docs: add required user permissions #23

Closed DanielMSchmidt closed 7 years ago

DanielMSchmidt commented 7 years ago

Hey there,

Thanks for this runner, it saved me a lot of time. Nevertheless I ran into the issue of my AWS user not having enough permissions to work properly, so I thought listing them here might spare the time of other people 👍

Hope this is complete and helps :)

DanielMSchmidt commented 7 years ago

@fadookie One question on top of that: your plugin makes it so easy to test on device farm by abstracting the AWS stuff away. It was abstracted so good away that it took me a good portion of time to find out that I need to upload the test bundle first (but not the app I assume?). Could you extend the documentation on this topic a bit so that the next users might not step into this problem?

I feel like I could add some information, but I haven't understood your solution completely yet, so I think you might give the best advice here.

fadookie commented 7 years ago

@DanielMSchmidt Yeah, this seems to be a pretty common pain point. I have a link to the other step in the description for this step as well as a mention in the description of the test_package_name input, but it doesn't seem to be enough for most people to understand. In fact, there was even a PR to combine them into a single step: https://github.com/peartherapeutics/bitrise-aws-device-farm-runner/pull/20

Unfortunately, I was not able to accept it as-is since it broke my company's use case - our test package is maintained by our QA engineer separate from our app's repo, and is uploaded by a separate CI job from our app itself.

I'm open to incorporating test upload functionality into this step to simplify things for the more common use case of having tests embedded in the app repo. But I don't really have time to do this myself. If you are interested in working on a PR to add this functionality in a manner that wouldn't break our workflow I think it would help make this a lot smoother. PR https://github.com/peartherapeutics/bitrise-aws-device-farm-runner/pull/20 could be used for reference or as a jumping off point. At the very least my review comments contain a suggested design for implementing such a change in a backwards-compatible manner.