search

peartherapeutics / bitrise-aws-device-farm-runner

Custom Bitrise step to run tests on aws device farm
MIT License
10 stars 21 forks source link

Feature/locale support #44

Closed crysxd closed 7 years ago

crysxd commented 7 years ago

I need to pass the locale de_DE to AWS CLI. I added a input "locale" which can be any of the locales supported by AWS and defaults to en_US, which is also AWS' default.

fadookie commented 7 years ago

Thanks! This looks great and is backwards-compatible. What platforms have you tested this with? I ask because IIRC, locale codes differ between Android and iOS. So I'm wondering if we need to offer separate settings.

crysxd commented 7 years ago

Thanks for asking! I actually did not thought of this issue before. Fortunately, the country/language codes do not need to match the system codes but are managed by AWS and are the same for Android/iOS. I pulled the codes from the "Create a new run > (4) Specify device state" screen in Device Farm.

I did only test the step with Android so far as we have massive issues triggering a run for iOS over the CLI (we encounter a known bug preventing us from starting a build...)