search

peartherapeutics / bitrise-aws-device-farm-runner

Custom Bitrise step to run tests on aws device farm
MIT License
10 stars 21 forks source link

Allow specifying the test-spec ARN #46

Closed LukasKnuthImagineOn closed 4 years ago

LukasKnuthImagineOn commented 6 years ago

When running the schedule-run-command via the AWS CLI, one can specify the test-spec that should be used for the run via the --test-flags testSpecArn property.

This would allow the user to create a test-spec in the AWS UI or CLI and specify it for a run, giving more control over the actual environment and process on the AWS Device Farm.

fadookie commented 5 years ago

I don't have time to add this right now but I am open to a backwards-compatible PR.

Donmclean commented 5 years ago

Related Bitrise Issue: https://discuss.bitrise.io/t/aws-device-farm-runner-does-not-support-custom-tests/7957

fadookie commented 5 years ago

Thanks for the heads up. This is a more appropriate place for issues and feature requests related to this step. I am still the maintainer of this step, not bitrise (at least for now.) Although unfortunately I don't think I'll be adding features myself anymore as it is no longer a priority at work as it already meets our needs. And I'm not going to work on it for free in my spare time.

But like I said I am happy to review PRs and answer questions in my spare time. I will take the PRs if the changes have been tested, documented, and are backwards-compatible. Thanks.

GuillaumeHemmen commented 5 years ago

Why not merging https://github.com/ginmon/bitrise-aws-device-farm-runner? He implemented test_spec to do that.

fadookie commented 5 years ago

@GuillaumeHemmen Like I said, feel free to send a PR. I don't have time to work on this myself now but I will try to carve out some time to at least review PRs.

elashpear commented 5 years ago

Goodness, I only just noticed you were linking to a fork. Nobody sent me a PR so I never noticed.

I opened https://github.com/peartherapeutics/bitrise-aws-device-farm-runner/pull/51 to track these changes and will try to review them soon.