peartherapeutics / bitrise-aws-device-farm-runner

Custom Bitrise step to run tests on aws device farm
MIT License
10 stars 20 forks source link

Required test_package_name with BUILTIN_EXPLORER. #47

Open abuenovanadis opened 5 years ago

abuenovanadis commented 5 years ago

Hi, i'm setup this step with this config:

Configs:

Why is missing this input if in AWS Device Farm isn't required for BUILTIN_EXPLORER

Thanks!

fadookie commented 5 years ago

Hey there - I never tested this use case. I don't have time to change this right now but I am open to taking a PR if it:

  1. Is fully backwards-compatible, and
  2. Maintains validation for test_package_name being required for all other test_types (unless you are aware of others that don't require a test package.)
fadookie commented 5 years ago

In the meantime, you could try uploading a dummy test package (maybe an empty zip file) and seeing if that will allow you to kick off the test run.

markhu commented 5 years ago

Related to https://github.com/peartherapeutics/bitrise-aws-device-farm-file-deploy/issues/15 and https://github.com/peartherapeutics/bitrise-aws-device-farm-file-deploy/issues/17