search

peartherapeutics / bitrise-aws-device-farm-runner

Custom Bitrise step to run tests on aws device farm
MIT License
10 stars 20 forks source link

BUILTIN_EXPLORER must not require test_package_name #48

Open abuenovanadis opened 5 years ago

abuenovanadis commented 5 years ago

Hello this PR is to change this issue:

https://github.com/peartherapeutics/bitrise-aws-device-farm-runner/issues/47

When you accepted the PR, could I access in bitrise? Thanks!

markhu commented 5 years ago

Similar issue with BUILTIN_FUZZ type of test not needing a test_package_name file. Also, the legend prompt text should be updated to clarify it is the test script, not the binary executable that is being tested.

abuenovanadis commented 5 years ago

I'm going to try in my local with cli.

abuenovanadis commented 5 years ago

I setup the same workflow in local, how can i use this new step in dev ?

Thanks!

fadookie commented 5 years ago

@abuenovanadis I am not sure what you mean by "use this step in dev" exactly. If you can run the tests in this repo it should be enough to verify if your changes to the step code actually work.

You can point your bitrise.yml to your fork and/or a specific commit instead of the official step from the steplib. So you may be able to fix this problem for yourself (which is great for testing), but nobody else will benefit unless I merge your changes and cut a new release.

If you could test this and also add BUILTIN_FUZZ to your whitelist that would be great. Thanks.