search

peartherapeutics / bitrise-aws-device-farm-runner

Custom Bitrise step to run tests on aws device farm
MIT License
10 stars 21 forks source link

Add test spec ARN input #51

Closed elashpear closed 4 years ago

elashpear commented 5 years ago

Closes https://github.com/peartherapeutics/bitrise-aws-device-farm-runner/issues/46

saiyenumula commented 4 years ago

Please someone can approve this PR @fadookie

fadookie commented 4 years ago

Sorry I have not had time to test it yet. I am planning on moving these repos over to the bitrise community organization soon so others can help maintain them as I don't even use them anymore.

vj-raghavan commented 4 years ago

Hi @fadookie, Can we help you with testing this ? Adding test spec to the list would help us in the work we are doing straight away. Please let me know if there is anything we can do to help ?

elashpear commented 4 years ago

@vj-raghavan to simplify testing I can merge this to a non-master branch so you can point directly at it from your bitrise.yml and test to see if it works.

FYI fadookie is my personal GH account, this is my work account.

elashpear commented 4 years ago

@vj-raghavan I've merged these changes to the ginmon-master branch. You can point your bitrise.yml to use this branch directly to verify that these changes do what's needed - I was not sure how to create a test case for this functionality.

We no longer use this step at my work so I am going to try to get it moved to the bitrise community org so it can be maintained there. If you're interested in being a new maintainer we could use one or more, I don't have time to do it anymore.

elashpear commented 4 years ago

Created a new PR to track movement of this code to master branch after testing is complete: https://github.com/peartherapeutics/bitrise-aws-device-farm-runner/pull/52

vj-raghavan commented 4 years ago

@elashpear I have been using the code in our pipeline and can confirm that this works as intended. I was thinking there might be something else that we need to be doing. But if its getting it run locally and verify that the changes work as intended it does.

Please merge it in.