peartherapeutics / bitrise-aws-device-farm-runner

Custom Bitrise step to run tests on aws device farm
MIT License
10 stars 21 forks source link

default inputs and deps update #7

Closed viktorbenei closed 8 years ago

viktorbenei commented 8 years ago

Added the new bin_name property - available in Bitrise CLI 1.4.0 and newer ;) - http://blog.bitrise.io/2016/09/13/monthly-release-of-bitrise-cli-sept.html

and default input values - it's usually a good idea to define default values

  1. for inputs which should be specified in Secrets, instead of directly for the input
  2. for inputs which will be most likely reused in another step, so it's enough to define it once, either as an App Env Var or Secret
fadookie commented 8 years ago

@viktorbenei looks good, this should also be fixed in https://github.com/bitrise-io/steps-amazon-s3-upload