Closed inducer closed 6 years ago
Good point. hashlib.md5(string).hexdigest()
ought to give a more robust solution, although there is a theoretical chance of the encountered issue reappearing. Let's keep your solution for correctness and where id is used only for visual, use its hash value.
Thanks for taking a look. We did encounter an issue (incorrectly parsed code, specifically, old parsing results being returned) when the
id
value matched a prior one. This code seems to use.id
as a cache key, which somewhat supports that. Having to hunt that explained the angry commit message. (Sorry!)