pebble-dev / RebbleOS

open source operating system for low-power smartwatches
Other
365 stars 38 forks source link

Music App - No Arm Animation + Double Free Fix #123

Closed AliceGrey closed 4 years ago

AliceGrey commented 4 years ago

Brought the music app back to a working state. Removed the record arm animation due to it being buggy and wanted to keep it simple. Added unique record colors. Fixed double free bug. Still needs API integration.

jwise commented 4 years ago

Looks great! I played with this using:

$ pebble repl --qemu localhost:63771
>>> import libpebble2.protocol.music as music
>>> pebble.send_packet(music.MusicControl(command = 0x10, data = music.MusicControlUpdateCurrentTrack(artist = b"Foo", album = b"Bar", title = b"Baz", track_length = 65, track_count = 7, current_track = 5)))
>>> pebble.send_packet(music.MusicControl(command = 0x11, data = music.MusicControlUpdatePlayStateInfo(state = 0x01, track_position = 15, play_rate = 1, shuffle = 0x01, repeat = 0x01)))

I also gave you push access to this repository so you can push into branches of your own; that way I can pull and rebase without having to fetch from your repository; please name your branches AliceGrey/music or things like that when you push to this repository. In theory only @ginge and I can push to master but I have no idea if that's actually true, so avoid that if you can.

Thanks for the work on bringing this up to the latest! Glad to have this merged in! I'll try to test on Asterix when I dig out from this GText and notification hole that I'm in.