Set alignment to MenuRowAlignCenter on submenu return

pebble-dev / RebbleOS

open source operating system for low-power smartwatches

Other

355 stars 38 forks source link

Set alignment to MenuRowAlignCenter on submenu return #138

Closed frbncis closed 3 years ago

frbncis commented 3 years ago

From what I was able to trace through:

Before entering the submenu, the menu alignment would be set to MenuRowAlignCenter
When returning from the submenu, alignment would be set to MenuRowAlignTop.

The difference in alignment caused changes on span_pos and frame_pos in _menu_layer_update_scroll_offset before and after the submenu.

Fixes #132 hopefully -- if this is not the case I wouldn't mind some pointers on where else I can investigate.

jwise commented 3 years ago

Nice work! I'll check it out tonight.

jwise commented 3 years ago

I think this doesn't quite fix the issue. But I think it does fix at least one issue! Here's a video of what I mean, so you can see how to replicate this issue:

https://user-images.githubusercontent.com/87427/107845201-ac64c180-6d8e-11eb-8482-2e85a7e8d326.mov

Thanks for taking a crack at it so far! I'm excited to see more people looking at contributing to RebbleOS!

frbncis commented 3 years ago

Thanks for the video! I'll see what I can dig up in the next little while.

frbncis commented 3 years ago

Ok, I think I've got it? Here's what it looks like now:

rebbleos_fix_submenu2

jwise commented 3 years ago

Nice work! This has been plaguing RebbleOS for a good long while, and I've never had time to look at it. Thanks much!