Open brunooss opened 3 years ago
The visual changes are great!
Looks like your editor went through and automatically reformatted the source (?), which makes the diff very difficult to read. Can you disable that behavior in your editor?
Also, it looks like you commented out the ifdef PBL_RECT
stuff -- I think this still probably won't look correct on Chalk (or does it?).
You're absolutely right, @jwise;
In my recent commit, I managed to fix that topics that you mentioned.
In fact, those were things that I made while debugging, and forgot to turn it back to normal! 😅
I left a bunch of comments (and then saw afterwards that you manually put the formatting back -- sorry for being nitpicky on that!). I think the only thing that I'd really like to see is confirmation that this works right when scrolling through multiple notifications. Having the status bar there will be great, especially for being able to put notification counters up there as we scroll (like PebbleOS) does.
Thanks so much again! And I'm also sorry that this took me so long to review again...
This is an improvement of the RebbleOS notifications, according to a prototype from Lavender Glaab that I've seen in the Discord Group. Here is how it looks like: