Initial Snowy, Tintin, and Chalk(?) support for About window

pebble-dev / RebbleOS

open source operating system for low-power smartwatches

Other

365 stars 38 forks source link

Initial Snowy, Tintin, and Chalk(?) support for About window #82

Closed tertty closed 5 years ago

tertty commented 5 years ago

Recreated from PR #115 in the old project per the request of @jwise

Snowy view

Tintin view

Chalk remains untested, could not get QEMU to boot.

Changes:

Only one line has been added to fix PNG transparency issues.

TODO:

[ ] Tintin still needs a rocket icon
[ ] If Chalk doesn't work, fix that
[x] Better link to Discord (pretty sure this one has expired)

jwise commented 5 years ago

Looks lovely. Does this need changes to the resource pack too?

tertty commented 5 years ago

The script itself is fine, just turned out to be an issue with my code. But I did add 4 new images (it says 3 in my commit, it's actually 4 but I only use 3), and that PR was made here.

jwise commented 5 years ago

https://rebble.io/discord is now a redirect.

jwise commented 5 years ago

Ok, I tested this on tintin, and found that if I scroll down in the about screen, something extremely exciting happens (the whole screen becomes corrupted and the systemapp seems to run out of memory). Can you have a look at that? I think the gbitmaps need to be freed. Other than that, good work! I've merged the resource pack into master.

Let me know when you're ready for me to retest and merge.

tertty commented 5 years ago

In my latest commit I added PBL_IF_COLOR_ELSE to pebble_defines.h. This helps with Pebble compatibility and also allows me to do: status_bar_layer_set_colors(status_bar, PBL_IF_COLOR_ELSE(GColorRed,GColorBlack), GColorWhite);

instead of: #ifdef PBL_BW (yuck!)

jwise commented 5 years ago

Man this is so cool and I'm super excited; I like the thoughtful style change to use StatusBarLayerSeparatorModeDotted for the header, and I wonder if we should propagate that in general to be the RebbleOS menu / alert dialog style. Great work, and I especially appreciate your responsiveness to my code style comments! Having a scroll layer also lays the groundwork for listing all of the authors in the about page, which I'm very excited to do.

I'll merge this now. Thanks again! 🚀