search

pebble / homebrew-pebble-sdk

Pebble Homebrew Tap
16 stars 22 forks source link

Update to 3.0-beta10 and fix version compare #8

Closed youtux closed 9 years ago

youtux commented 9 years ago

Due to the new gevent dependency, now the PATH variable should include the libexec/bin directory, so that the gevent package can compile succesfully using cython.

I included also a version fix, otherwise users which have the 3.0-dp9 or less installed could not upgrade, because the default Homebrew version parser consider "dp9" a StringToken, and the comparison with a BetaToken (beta10) fails.

cjwilliams commented 9 years ago

Thanks, great fix!

youtux commented 9 years ago

I have got some feedback from my colleagues, and it seems that even with the custom version implementation the formula will not upgrade from any dp* to the beta version. This seems to be caused by the implementation of outdated_brews, where the version that Homebrew gets looking at the /usr/local/Cellar/pebble-sdk/ directory is parsed using the standard Homebrew's Version class, not the one provided by pebble-sdk. I will open an issue on Homebrew and see what they think.

EDIT: fixed wrong link.