search

peburrows / diplomat

Elixir library for interacting with Google's Cloud Datastore
94 stars 22 forks source link

Improve `Entity` Typespecs #22

Closed cjab closed 7 years ago

cjab commented 7 years ago

This fixes several type errors in the the Entity module. Most of them are around possible nil values and cases in which an invalid Key could be constructed by the Entity. If I understand correctly a Key must have a kind, while name and id are optional. In the past it was possible to create an entity with a nil kind and id which would build a Key without a kind.

This also ignores type errors within exprotobuf, at least for now.

peburrows commented 7 years ago

Tagged v0.7.1 and published to hex.