search

peburrows / goth

Elixir package for Oauth authentication via Google Cloud APIs
http://hexdocs.pm/goth
MIT License
284 stars 108 forks source link

Fix deprecation warning with finch 0.17 #168

Closed dvic closed 8 months ago

dvic commented 8 months ago

Finch 0.17 deprecated the protocol pool option: https://github.com/sneako/finch/commit/334af8efdcae2e38a47c5f572e4225f7cf04de1e

This PR checks the Finch version at runtime and passes the appropriate pool option.

dvic commented 8 months ago

Ooops, totally missed #167 and the suggestion to drop the pools option altogether. Feel free to close this if that is preferred to this PR.

wojtekmach commented 8 months ago

Thanks for the PR, closing in favour of #167!