search

peburrows / goth

Elixir package for Oauth authentication via Google Cloud APIs
http://hexdocs.pm/goth
MIT License
289 stars 111 forks source link

Allow for the project_id to be overridden manually #20

Closed peburrows closed 7 years ago

peburrows commented 7 years ago

Google permissions can work in a very strange (kinda magic?) way where a service account can be given permissions in a project to which is does not actually belong. In order to support this, we need to allow for the project_id to be manually overridden in the config (instead of always reading it from the credentials json).

dazuma commented 7 years ago

I'm a bit unclear what the "project_id" field is actually being used for in the library. But this change itself sounds good to me. Also see https://github.com/peburrows/goth/issues/21

dazuma commented 7 years ago

This was superseded by https://github.com/peburrows/goth/pull/22. Suggest we close it.