search

peburrows / goth

Elixir package for Oauth authentication via Google Cloud APIs
http://hexdocs.pm/goth
MIT License
289 stars 111 forks source link

sub Support #29

Closed chengyin closed 6 years ago

chengyin commented 6 years ago

I noticed that there are two PRs (#7, #12) on this. Before I try to work on the 3rd one, is this something this lib wants to support?

chengyin commented 6 years ago

The new actor_email config only applies to one user. What if I need to dynamically change who to personate in each call?

peburrows commented 6 years ago

Currently, there's no way to do this dynamically, unfortunately. The actor_email config was added to fill the gap in functionality, but longer term I'd like to provide a more flexible way of doing things.

I might have some time to work on this feature next week, but as always, PRs are more than welcomed!

chengyin commented 6 years ago

I made the changes since I need the feature. PTAL at the PR. Thanks!