return {:error, err} from Client.get_access_token/2 instead of crashing

peburrows / goth

Elixir package for Oauth authentication via Google Cloud APIs

http://hexdocs.pm/goth

MIT License

289 stars 111 forks source link

return {:error, err} from Client.get_access_token/2 instead of crashing #40

Closed peburrows closed 6 years ago

martin-cernak commented 6 years ago

Will this be merged any time soon ?

peburrows commented 6 years ago

Sorry, just got back from my honeymoon recently, and with all the wedding chaos leading up to it, had kind of lost track of some of my open source stuff.

I'll get this merged and will cut a new release soon.

martin-cernak commented 6 years ago

Thank you and congratulation :)

peburrows commented 6 years ago

After looking into merging this, it appears master has diverged significantly enough since I wrote this code that I'm going to have to go back and refactor / cleanup a lot of this implementation as it currently breaks a few things in master.

peburrows commented 6 years ago

Closing in favor of the refactored #47