search

peburrows / goth

Elixir package for Oauth authentication via Google Cloud APIs
http://hexdocs.pm/goth
MIT License
289 stars 111 forks source link

dynamically add account configs #43

Closed amenck closed 6 years ago

amenck commented 6 years ago

While using this module for an application, a use-case came up to dynamically add service users (defined at runtime by using admin APIs). I do not believe any of the existing config definition methods allow this, so I went ahead and added a function to allow this in the Config module.

Let me know if there is a preferable implementation here, or an existing way to get the same functionality.

amenck commented 6 years ago

@peburrows any thoughts on this one?

peburrows commented 6 years ago

I think this makes sense. I'll get it merged and released as soon as I get a chance.

peburrows commented 6 years ago

Merged and included in the v0.10.0 release.

Thanks!