search

peburrows / goth

Elixir package for Oauth authentication via Google Cloud APIs
http://hexdocs.pm/goth
MIT License
284 stars 108 forks source link

Extract getting envs to app top level #45

Closed aleklisi closed 4 years ago

aleklisi commented 6 years ago

Pull request does not change existing functionality, but it allows to start goth on demand (with Goth.Supervisor.start_link([{:json, json}]) and not when app starts.

michalwski commented 6 years ago

This change can be beneficial for many users of the lib. Can this be merged into master branch, @peburrows?

peburrows commented 5 years ago

Thanks, I'll review and get this merged soon.

lcezermf commented 5 years ago

@aleklisi @peburrows any changes about it?

peburrows commented 5 years ago

Sorry, I just kind of lost track of this PR. Taking a look now, though, it looks like tests are failing.

lcezermf commented 5 years ago

@peburrows seems a compilation error:

== Compilation error on file lib/goth/config.ex ==
** (CompileError) lib/goth/config.ex:54: undefined function config/0
    (stdlib) lists.erl:1337: :lists.foreach/2
    (stdlib) erl_eval.erl:669: :erl_eval.do_apply/6
peburrows commented 5 years ago

Yes, and that error isn't happening in master. It's related to this change, so that will need to be resolved first.

peburrows commented 5 years ago

Looks like there's still a failing test for this PR.

rjacobskind commented 5 years ago

I would love to see this PR merged in

aleklisi commented 5 years ago

I have fixing the PR on my TODO list, but have other stuff with a bit higher priority :(

peburrows commented 4 years ago

Thanks to @rjacobskind's work on #63, this has finally been released (available in v1.2.0).