search

peburrows / goth

Elixir package for Oauth authentication via Google Cloud APIs
http://hexdocs.pm/goth
MIT License
284 stars 108 forks source link

Remove the `warnings_as_errors` compiler option #80

Closed lytedev closed 3 years ago

lytedev commented 3 years ago

This will enable newer versions of Elixir to run the tests and pass. While warnings should probably be resolved, many of them exist in underlying dependencies, and should therefore not fail the suite.

wojtekmach commented 3 years ago

Thank you!

While warnings should probably be resolved, many of them exist in underlying dependencies, and should therefore not fail the suite.

--warnings-on-errors does not fail compiling dependencies (there might have been a bug in one of the Elixir versions that did, however) so it's totally fine option to use, especially on CI.