Support borders in Neovim

pechorin / any-jump.vim

Jump to any definition and references 👁 IDE madness without overhead 🚀

1.07k stars 40 forks source link

Support borders in Neovim #115

Open toupeira opened 2 months ago

toupeira commented 2 months ago

Thanks for the great plugin!

This adds window border support for Neovim, disabled by default.

I saw there was some previous interest in https://github.com/pechorin/any-jump.vim/issues/27, https://github.com/pechorin/any-jump.vim/issues/77, and https://github.com/pechorin/any-jump.vim/pull/74.

Two questions:

Does this need more/clearer docs?
Is it okay if this is Neovim-only? Looks like popup_menu() supports borders too, but in a different format: https://vimhelp.org/popup.txt.html#popup_create-arguments.

toupeira commented 2 months ago

Hmm I had an idea: Instead of adding this border setting we could also add a generic "window options" dictionary, so users could pass any of the available options for nvim_open_win() or popup_menu(). These would be merged with the existing options in plugin/any-jump.vim.

What do you think? I would probably add two separate dictionaries for Vim and Neovim, and call it something like g:any_jump_vim_window_options and g:any_jump_nvim_window_options.

toupeira commented 1 month ago

@pechorin hi there, friendly ping in case you didn't see this yet :wink:

Curious to hear your thoughts on my idea in https://github.com/pechorin/any-jump.vim/pull/115#issuecomment-2096948472