search

pecigonzalo / docker-machine-vmwareworkstation

VMWare Workstation driver for Docker Machine https://github.com/docker/machine
Apache License 2.0
363 stars 67 forks source link

Merge with upstream? #25

Closed gtirloni closed 8 years ago

gtirloni commented 8 years ago

First, thank you very much for working on this. It makes life more bearable for some of us using VMware.

I can report it worked great with VMware Workstation 12.1 on Windows 10 (AU).

Are you considering submitting this upstream to Docker?

pecigonzalo commented 8 years ago

@gtirloni Great to hear this! and i love knowing is helping other people. I did submit this upstream, but i was asked by the docker team to keep it as plugin.

You can check the info here: https://github.com/docker/machine/pull/2300

gtirloni commented 8 years ago

It's unfortunate they won't accept it. It would be a much better experience for end users (and the driver could always be dropped if they lack the bandwidth to support it).

I guess now that they have released Docker for Win/Mac and it depends on Hyper-V/xhyve, we might not be seeing much activity on Docker Machine and Docker Toolbox, but that's just a hunch.

Thanks again, really appreciated!

StefanScherer commented 8 years ago

@gtirloni Just curious. How do you have installed docker-machine and this plugin? Through Chocolatey or downloaded the binaries manually?

gtirloni commented 8 years ago

@StefanScherer I downloaded the plugin manually and put it in the Docker Toolbox folder like this.

StefanScherer commented 8 years ago

@gtirloni Thanks for the link and how you made it work for you.

pecigonzalo commented 8 years ago

@gtirloni Mind if i put those steps on the README? they might help other people

gtirloni commented 8 years ago

No worries. Thank you.

On Aug 7, 2016 08:39, "Gonzalo Peci" notifications@github.com wrote:

@gtirloni https://github.com/gtirloni Mind if i put those steps on the README? they might help other people

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pecigonzalo/docker-machine-vmwareworkstation/issues/25#issuecomment-238077679, or mute the thread https://github.com/notifications/unsubscribe-auth/AFoR7jPRlBFdVN3l4E1KrJZKWtxkZhjDks5qdcPigaJpZM4JdUeb .