search

peckadesign / pd-naja

1 stars 0 forks source link

Title is not reverted to previous state when closing the modal #26

Open janchaloupka opened 4 months ago

janchaloupka commented 4 months ago

I have encountered a problem with dynamic page title. On opening a modal the page title reflects the change. However when closing the modal the title is not updated back to its original value.

Steps to reproduce the problem:

  1. have dynamic snippet that redraws when opening a modal</li> <li>open the modal window - the page title should have changed to the modals title</li> <li>now close the modal (either from site interaction or via the back button)</li> <li>the title does not revert to the previous value</li> </ol> <p>I suspect the problem is somewhere in the history state as I noticed the page title is overwritten even for the previous history entry.</p> <p>@zipper can you please look into it?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/zipper"><img src="https://avatars.githubusercontent.com/u/3872371?v=4" />zipper</a> commented <strong> 4 months ago</strong> </div> <div class="markdown-body"> <p>Solved in <a href="https://github.com/peckadesign/pd-naja/pull/27">https://github.com/peckadesign/pd-naja/pull/27</a>, released in <a href="https://github.com/peckadesign/pd-naja/releases/tag/2.3.1">https://github.com/peckadesign/pd-naja/releases/tag/2.3.1</a>. The title is now correctly changing back.</p> <p>There is still one issue remaining with the history entry itself, see <a href="https://github.com/naja-js/naja/issues/406">https://github.com/naja-js/naja/issues/406</a>.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>