search

pecos / tps

Torch Plasma Simulator
BSD 3-Clause "New" or "Revised" License
8 stars 2 forks source link

Fix integration order for Lobatto basis with square element #172

Closed dreamer2368 closed 2 years ago

dreamer2368 commented 2 years ago

So far, integration order has been erroneously adjusted when the Gauss-Lobatto basis is used with square element, as below:

if (intRuleType == 1 && vfes->GetFE(i)->GetGeomType() == Geometry::SQUARE)
      integrationOrder--;  // when Gauss-Lobatto

This somehow passed the consistency test with the time integration. However, it does not pass the convergence test with utils/compute_rhs. After this fix, the errors of manufactured solutions significantly decreased (about a factor of 4).

Beside this, another manufactured solution test mms_euler_2d is added.